Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upgrading new ESP32 board types #1140

Closed
jamesmyatt opened this issue Oct 23, 2023 · 13 comments · Fixed by #1332
Closed

Add support for upgrading new ESP32 board types #1140

jamesmyatt opened this issue Oct 23, 2023 · 13 comments · Fixed by #1332
Labels
new-feature New features or options. stale There has not been activity on this issue or PR for quite some time.

Comments

@jamesmyatt
Copy link

What needs to be done to add upgrade support for the new ESP32 board types, like ESP32-C3? With https://github.com/Aircoookie/WLED/releases/tag/v0.14.0, there's "-S2/-C3/-S3" (initial) support.

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/wled/helpers.py", line 28, in handler
    await func(self, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/components/wled/update.py", line 88, in async_install
    await self.coordinator.wled.upgrade(version=version)
  File "/usr/local/lib/python3.11/site-packages/wled/wled.py", line 661, in upgrade
    raise WLEDUpgradeError(msg)
wled.exceptions.WLEDUpgradeError: Upgrade is only supported on ESP01, ESP02, ESP32 and ESP8266 devices

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 226, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 2012, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2049, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service
    return await service.entity_service_call(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 876, in entity_service_call
    response_data = await _handle_entity_call(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 948, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 157, in async_install
    await entity.async_install_with_progress(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 432, in async_install_with_progress
    await self.async_install(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/wled/helpers.py", line 37, in handler
    raise HomeAssistantError("Invalid response from WLED API") from error
homeassistant.exceptions.HomeAssistantError: Invalid response from WLED API
@jamesmyatt
Copy link
Author

There's also an "ESP32_audioreactive" build that will presumably be upgraded to the regular "ESP32" build currently. So I think the best solution is for WLED to provide the release name itself via API, and I've raised Aircoookie/WLED#3497. @frenck what do you think?

Copy link

github-actions bot commented Dec 3, 2023

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Dec 3, 2023
@jamesmyatt
Copy link
Author

This is still open

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Dec 4, 2023
Copy link

github-actions bot commented Jan 4, 2024

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jan 4, 2024
@jamesmyatt
Copy link
Author

This is still open. I'm planning to submit something.

@jamesmyatt
Copy link
Author

jamesmyatt commented Jan 8, 2024

FWIW, I don't see my proposal in Aircoookie/WLED#3497 going anywhere without more support, so it's going to have to stick to guessing.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jan 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Feb 9, 2024
@jamesmyatt
Copy link
Author

This is still open. I'm still planning to submit something.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Feb 10, 2024
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 11, 2024
@jamesmyatt
Copy link
Author

jamesmyatt commented Mar 13, 2024

This is still open. Is there a way to stop it getting stale? It's definitely needed.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Mar 14, 2024
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Apr 14, 2024
@jamesmyatt
Copy link
Author

still open

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Apr 16, 2024
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options. stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants