Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable_protection for a specific duration #1030

Open
rbeuque74 opened this issue May 3, 2024 · 0 comments · May be fixed by #1033
Open

Allow to disable_protection for a specific duration #1030

rbeuque74 opened this issue May 3, 2024 · 0 comments · May be fixed by #1033

Comments

@rbeuque74
Copy link

Problem/Motivation

Since AGH v0.107.28, AGH allow to disable protection for a specific duration (see AdguardTeam/AdGuardHome#1333).
This option is not present in disable_protection, hence, cannot be used in Home Assistant, using a service.

Expected behavior

Having an optional pause_duration_miliseconds parameter.

Proposed changes

  • switch URL to POST /protection
  • add an optional parameter to disable_protection
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue May 3, 2024
@rbeuque74
feat: add disable protection for a specific duration
c88ee02 
Fixes frenck#1030

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue May 3, 2024
@rbeuque74
feat: add disable protection for a specific duration
e625d71 
Fixes frenck#1030

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
@rbeuque74 rbeuque74 linked a pull request May 3, 2024 that will close this issue
Open
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue May 3, 2024
@rbeuque74
feat: add disable protection for a specific duration
d106c05 
Fixes frenck#1030

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add disable protection for a specific duration rbeuque74/python-adguardhome
1 participant
@rbeuque74