-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version attribute as action output #16
Conversation
I can see this being helpful for some add-ons structures, but in a CI/CD automated environment, it doesn't make much sense to me. Versions should be defined by things like releases or git tags. |
I will use it as tags for my addons which is indeed not a good practice for releasing them. Since its still a freetime-project I have currently no motivation to come up with a complex release structure or splitted add-on repositories. The version is also an basic attribute of an addon as well which could be used also in CI. Thinking about checks of matching versions of Changelog and config.json and automatic tag creation on master pushes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
But needs adjustments to the README/documentation.
Will do this evening. What exactly do you address @frenck ? |
Ah, forget the comment before ;)
|
The prettier should now be happy as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Poeschl 👍
During using the information addon, I was missing the version attribute. This PR adds it as additional output.