Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version attribute as action output #16

Merged
merged 3 commits into from
May 30, 2021
Merged

Add version attribute as action output #16

merged 3 commits into from
May 30, 2021

Conversation

Poeschl
Copy link
Contributor

@Poeschl Poeschl commented May 24, 2021

During using the information addon, I was missing the version attribute. This PR adds it as additional output.

@Poeschl Poeschl requested a review from frenck as a code owner May 24, 2021 19:25
@frenck
Copy link
Owner

frenck commented May 25, 2021

I can see this being helpful for some add-ons structures, but in a CI/CD automated environment, it doesn't make much sense to me.

Versions should be defined by things like releases or git tags.

@Poeschl
Copy link
Contributor Author

Poeschl commented May 25, 2021

I will use it as tags for my addons which is indeed not a good practice for releasing them. Since its still a freetime-project I have currently no motivation to come up with a complex release structure or splitted add-on repositories.

The version is also an basic attribute of an addon as well which could be used also in CI. Thinking about checks of matching versions of Changelog and config.json and automatic tag creation on master pushes.

Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

But needs adjustments to the README/documentation.

@Poeschl
Copy link
Contributor Author

Poeschl commented May 25, 2021

Will do this evening. What exactly do you address @frenck ?

@Poeschl
Copy link
Contributor Author

Poeschl commented May 25, 2021

Ah, forget the comment before ;)

  • grabs full cup of coffee

@Poeschl Poeschl requested a review from frenck May 25, 2021 09:34
@Poeschl
Copy link
Contributor Author

Poeschl commented May 29, 2021

The prettier should now be happy as well

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Poeschl 👍

@frenck frenck added the new-feature New features or options. label May 30, 2021
@frenck frenck merged commit 9c37dc6 into frenck:main May 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants