Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Add missing documentation for Jane's design options #6739

Closed
joostdecock opened this issue May 12, 2024 · 1 comment 路 Fixed by #6747
Closed

[docs]: Add missing documentation for Jane's design options #6739

joostdecock opened this issue May 12, 2024 · 1 comment 路 Fixed by #6747
Assignees
Labels
馃摉 documentation Documentation 馃憤 good first issue An issue that you can take on without much prerequisite knowledge or experience

Comments

@joostdecock
Copy link
Member

Where can we see the problem? 馃

http://localhost:8000/docs/designs/jane

Suggested content

Please add docs for the options in Jane.

Additional context

Note that I've already created all the folders and files in #6738 you just have to write the descriptions.

@joostdecock joostdecock added 馃摉 documentation Documentation 馃憤 good first issue An issue that you can take on without much prerequisite knowledge or experience labels May 12, 2024
@bobgeorgethe3rd
Copy link
Contributor

bobgeorgethe3rd commented May 13, 2024

  • Missing design option documentation
  • Missing designer note documentation
  • Incorrect dates. 1790s not 1970s
  • options.sleeveLength would actually be sleeveLengthBonus hence why it was originally sleeveBonus. Really the sleeve length is set due to the time period of the garment and the option is simply adding more so it should be bonus rather than just length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃摉 documentation Documentation 馃憤 good first issue An issue that you can take on without much prerequisite knowledge or experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants