Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Warn on impossible physical measurements #6576

Open
HaasJona opened this issue Apr 17, 2024 · 3 comments
Open

[feature]: Warn on impossible physical measurements #6576

HaasJona opened this issue Apr 17, 2024 · 3 comments
Labels
馃拵 enhancement New feature or request

Comments

@HaasJona
Copy link
Contributor

What is it that you would like to see happen? 馃

The measurement set dialog should warn when the user enter values that are physically impossible and will likely cause issues when drafting a pattern. The scope of this feature request is limited to warning about measurements that are (almost鹿) impossible. This is not supposed to warn about measurements that are simply uncommon, scaled up/down for dolls, statues, and so on, or which are simply different from some assumed standard body type.

鹿) People with amputations or limb transplants or measurement sets that are used for non-human-shaped dolls or animals might get a warning, but there's not much we can do about it as you might need to fake some measurements or manually adjust the patterns anyway...

I propose the following checks:

Upper body front vertical measurements

HPS to waist front > HPS to bust
HPS to waist front > Waist to underbust

Arm measurements

Shoulder to wrist > Shoulder to elbow

Lower body vertical measurements

Waist to floor > Waist to knee > Waist to upper leg > Waist to seat > Waist to hips
Waist to floor > Inseam

Measurements that are strictly defined as part of another measurement

Cross seam > Cross seam front
Seat circumference > Seat back
High bust > High bust front
Chest circumference > Bust front > Bust span

(If I forgot something or you think something is incorrect, please leave a comment)

Also none of the length measurements should be zero or negative. Like even if the waist sits (almost) on the underbust or on the hips, you probably still want to enter a small positive measurement to prevent errors in pattern construction.

Additional context

No response

@HaasJona HaasJona added the 馃拵 enhancement New feature or request label Apr 17, 2024
@joostdecock
Copy link
Member

@HaasJona I think this might make more sense on the roadmap, rather than as an open issue?

As in, we could add it to the roadmap since I think we all agree that we want this, and then link to this (closed) issue.

What do you think?

@joostdecock
Copy link
Member

Oops, clicked the wrong button 馃檲

@joostdecock joostdecock reopened this Apr 28, 2024
@HaasJona
Copy link
Contributor Author

Sure, that sounds sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃拵 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants