Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Change input type for number fields #6542

Closed
karlnippoldt opened this issue Apr 11, 2024 · 0 comments · Fixed by #6763
Closed

[feature]: Change input type for number fields #6542

karlnippoldt opened this issue Apr 11, 2024 · 0 comments · Fixed by #6763
Assignees
Labels
💎 enhancement New feature or request

Comments

@karlnippoldt
Copy link
Contributor

karlnippoldt commented Apr 11, 2024

What is it that you would like to see happen? 🤔

Right now, number fields in FreeSewing use <input type="number">. This provides the advantage of a number keyboard when using a software keyboard and (mostly) limiting keys entered to numerical values. However, it has a number of disadvantages, most noticeably, when the user scrolls while the field is in focus, the number value changes in addition to the page scrolling. This can result in unintended changes to the number fields. I've noticed this most on the measurements entry page, but it may be elsewhere as well. There are accessibility issues with this field type as well. Changing these fields to <input type="text" inputmode="numeric" pattern="[0-9]*"> will address these issues, among others.

See more info on the issue and how the fix was implemented on gov.uk Why the GOV.UK Design System team changed the input type for numbers.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants