Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Ruby 1.9 #552

Closed
wants to merge 8 commits into from
Closed

Drop support for Ruby 1.9 #552

wants to merge 8 commits into from
+53 −185

Conversation

wasabigeek
Copy link
Contributor

@wasabigeek wasabigeek commented Sep 18, 2022 •
edited
Loading

Follow-up to #555, related to #325, and also unblocks #446.

Closes #547 🙇 (sorry about that @nitishr)

@floehopper
Copy link
Member

Do we need to warn users of earlier versions, similar to c5f8496?

Yes, ideally I would like to do this. I should have some availability to get a new Mocha release out in the next week or two which could include such a deprecation.

@floehopper
Copy link
Member

Do we need to warn users of earlier versions, similar to c5f8496?

Yes, ideally I would like to do this. I should have some availability to get a new Mocha release out in the next week or two which could include such a deprecation.

I've just merged #555 and released v1.15.0 of the gem. Hopefully this unblocks things a bit for this PR. 🤞

@wasabigeek
Set required Ruby > 2.0
5ef03a3
@wasabigeek
Replace RUBY_V2_PLUS with true in stubbed_method
9361f8e
@wasabigeek
Remove orphaned else flow

Verified

This commit was signed with the committer’s verified signature.
carllerche Carl Lerche
GPG key ID: AA14CE6F061D8F7A
Verified
Learn about vigilant mode
33f8cb9
@wasabigeek
Remove orphaned flow from restore_original_method

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ff3d62d
@wasabigeek
Remove restore_original_method
838abd4
@wasabigeek
Remove RUBY_V2_PLUS
c91c9ff
@wasabigeek wasabigeek changed the title Spike dropping support for Ruby 1.9 Drop support for Ruby 1.9 Sep 22, 2022
@wasabigeek wasabigeek marked this pull request as ready for review September 22, 2022 15:32
@wasabigeek
Copy link
Contributor Author

Thanks @floehopper! Updated the PR, I may have missed something, but all the tests are passing 👍

floehopper
floehopper requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty good to me, but I've spotted a few minor things which would be good to resolve before merging. Thanks again for all your work on this.

floehopper
floehopper approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes to the test name(s) that you've suggested. Otherwise this looks good to me. 👍

@wasabigeek wasabigeek deleted the remove-ruby-1.9 branch September 25, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floehopper floehopper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wasabigeek @floehopper