Fix misleading exception in has_entry
#513
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
has_entry
is called without any arguments, it will raise anexception like the following:
This is because we don't check if the
options.length
is zero so whenit is, the
else
branch executes and prints the above error. We can fixthis by simply adding another branch to cover the case when
options.length
is zero.Unfortunately, this change introduces a new RuboCop violation:
We could disable the cop but I didn't feel like it was my call to make. I'll leave that up to y'all.