Avoid calling Kernel#format from ObjectMethods#mocha_inspect #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously setting an expectation on an instance of a class that defined a custom `format` method resulted in incorrect information being displayed or an ArgumentError if the arity of the `format` method was different from `Kernel#format`. By calling `Kernel.format` directly we can avoid this problem. Fixes #342.
floehopper
deleted the
avoid-calling-kernel-format-from-object-methods-mocha-inspect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly tweaked version of #343.
Previously setting an expectation on an instance of a class that defined a custom
formatmethod resulted in incorrect information being displayed or an ArgumentError if the arity of theformatmethod was different fromKernel#format. By callingKernel.formatdirectly we can avoid this problem.Fixes #342.