Avoid mocks for partial mocking leaking into subsequent tests #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ObjectMethods#mocha & ClassMethods::AnyInstance#mocha were building mock objects for ancestor classes when ObjectReceiver#mocks or AnyInstanceReceiver#mocks was called from Mock#all_expectations as part of Mock#method_missing. Since these mock objects were not associated with a corresponding ClassMethod or AnyInstanceMethod registered with Central via Mockery#mock_impersonating or Mockery#mock_impersonating_any_instance_of, they were not being reset as part of Central#unstub_all via Mockery#teardown and this state was leaking into subsequent tests. You can see an example of this in #298. I've captured a more general case of this in the new acceptance test method in StubAnyInstanceMethodDefinedOnSuperclassTest which was failing before the fix in this commit. I've also added a similar acceptance test method to StubClassMethodDefinedOnSuperclassTest which was also failing before the fix in this commit. I'm not particularly happy with the fix, but I think it'll do for now.
floehopper
deleted the
avoid-mocks-for-partial-mocking-leaking-into-subsequent-tests
branch
|
Released in v1.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ObjectMethods#mocha&ClassMethods::AnyInstance#mochawere building mock objects for ancestor classes whenObjectReceiver#mocksorAnyInstanceReceiver#mockswas called fromMock#all_expectationsas part ofMock#method_missing.Since these mock objects were not associated with a corresponding
ClassMethodorAnyInstanceMethodregistered withCentralviaMockery#mock_impersonatingorMockery#mock_impersonating_any_instance_of, they were not being reset as part ofCentral#unstub_allviaMockery#teardownand this state was leaking into subsequent tests.You can see an example of this in #298. I've captured a more general case of this in the new acceptance test method in
StubAnyInstanceMethodDefinedOnSuperclassTestwhich was failing before the fix in this commit.I've also added a similar acceptance test method to
StubClassMethodDefinedOnSuperclassTestwhich was also failing before the fix in this commit.I'm not particularly happy with the fix, but I think it'll do for now.