move minitest to the correct namespace

[grosser]

had to open the gem to figure out why require 'mocha/minitest' did not work :(
... just a quickfix, proper move should happen in the next major release ...

@floehopper

[floehopper]

@grosser:

Thanks for the PR. I can see why this is surprising, although, in my defence, I think the problem originally lay with minitest, because the namespace was originally MiniTest. Also the correct require statement is mentioned several times in the Mocha README, e.g. here, here & here, so no need to open the gem source.

I think I might fix the problem by adding the mocha/mini_test.rb file, but leaving mocha/minitest.rb in place, but with a deprecation warning. What do you think?

[grosser]

you mean adding a deprecation to mini_test.rb ? (there already is a mini_test.rb)

…

On Sun, Jan 28, 2018 at 3:43 AM, James Mead ***@***.***> wrote: @grosser <https://github.com/grosser>: Thanks for the PR. I can see why this is surprising, although, in my defence, I think the problem originally lay with minitest, because the namespace was originally MiniTest <https://ruby-doc.org/stdlib-2.1.0/libdoc/minitest/rdoc/MiniTest.html>. Also the correct require statement is mentioned several times in the Mocha README, e.g. here <https://github.com/freerange/mocha/blob/0426e5ec119bc6a6c0ab256c2b3a8273d798a6c0/README.md#minitest>, here <https://github.com/freerange/mocha/blob/0426e5ec119bc6a6c0ab256c2b3a8273d798a6c0/README.md#minitest-1> & here <https://github.com/freerange/mocha/blob/0426e5ec119bc6a6c0ab256c2b3a8273d798a6c0/README.md#minitest-2>, so no need to open the gem source. I think I might fix the problem by adding the mocha/mini_test.rb file, but leaving mocha/minitest.rb in place, but with a deprecation warning. What do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#320 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ65rhX--BWqOPXOaWMBQFH4AYfj7ks5tPF11gaJpZM4RvkZ_> .

[floehopper]

Yes - sorry I got that the wrong way round. I should have said:

I think I might fix the problem by adding a mocha/minitest.rb file, but leaving mocha/mini_test.rb in place, but with a deprecation warning and requiring the new mocha/minitest.rb file to avoid duplication. What do you think?

[grosser]

ok, updated

…

On Sun, Jan 28, 2018 at 8:04 AM, James Mead ***@***.***> wrote: Yes - sorry I got that the wrong way round. I should have said: I think I might fix the problem by adding a mocha/minitest.rb file, but leaving mocha/mini_test.rb in place, but with a deprecation warning and requiring the new mocha/minitest.rb file to avoid duplication. What do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#320 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ2Ef7cywGVizyir6HAu6ACUTKyfhks5tPJqXgaJpZM4RvkZ_> .

[floehopper]

Addressed in #322. Closing.

[floehopper]

@grosser I've just released v1.4.0 which includes the fix for this. Let me know if you run into any problems with it.

[grosser]

works!

…

On Tue, Mar 20, 2018 at 12:55 PM, James Mead ***@***.***> wrote: @grosser <https://github.com/grosser> I've just released v1.4.0 <v1.3.0...v1.4.0> which includes the fix for this <#324>. Let me know if you run into any problems with it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#320 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ50sp1stqHsoGBERijpb5L_QVARwks5tgV6sgaJpZM4RvkZ_> .