Display file and line number in deprecation warning #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing against |
The newlines before and after each deprecation warning and the multiple leading asterisks make the warnings are a bit over the top, especially when lots of them occur within a test suite.
Fixes #312. I've also removed the code which displayed the backtrace for deprecation warnings in debug mode, because this is now redundant.
This is now redundant.
floehopper
force-pushed
the
display-file-and-line-number-in-deprecation-warning
branch
from
7d13697
to
6e40487
Compare
|
The Travis CI build has now passed and so I'm happy to merge this. |
floehopper
deleted the
display-file-and-line-number-in-deprecation-warning
branch
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the output from:
To:
Mocha::Deprecation- now only:enabledor:disabledare validFixes #312.