Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for assert_nil in ClassMethodTest #308

Closed
floehopper opened this issue Aug 24, 2017 · 0 comments · Fixed by #309
Closed

Fix deprecation warning for assert_nil in ClassMethodTest #308

floehopper opened this issue Aug 24, 2017 · 0 comments · Fixed by #309
Assignees

Comments

@floehopper
Copy link
Member

$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

$ bundle list | grep minitest
  * minitest (5.10.3)

$ bundle exec ruby -Itest test/unit/class_method_test.rb -n test_should_return_mock_for_stubbee
Run options: -n test_should_return_mock_for_stubbee --seed 24035

# Running:

DEPRECATED: Use assert_nil if expecting nil from test/unit/class_method_test.rb:185. This will fail in Minitest 6.
.

Finished in 0.002643s, 378.2878 runs/s, 378.2878 assertions/s.

1 runs, 1 assertions, 0 failures, 0 errors, 0 skips
@floehopper floehopper self-assigned this Aug 24, 2017
floehopper added a commit that referenced this issue Aug 24, 2017
These unit tests are pretty horrible and this one in particular didn't
seem to be testing anything useful. The fix makes it test the
`ClassMethod#mock` slightly more convincingly and avoids the deprecation
warning.

Fixes #308.
This was referenced Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant