Add latest stable version of JRuby to Travis CI build matrix #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @headius fixed jruby/jruby#4250 and it was released in JRuby v9.1.6.0, the Mocha unit & acceptance tests have all been passing under this latest version of JRuby.
However, an assertion related to the stack-trace from a Mocha exception was failing under JRuby for both Minitest & Test::Unit (see this comment for details). This PR filters out JRuby-related lines of the stack-trace thus fixing the assertions.
Finally this PR also adds JRuby to the Travis CI build matrix in the hope that we can prevent regressions in the future.