Simplify implementation of String#mocha_inspect. #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I overlooked this, but it looks good to me 👍 |
chrisroos
force-pushed
the
fix-mocha-inspect-on-strings
branch
from
130b0ff
to
75fcee5
Compare
|
I've just rebased this on master and force pushed. I'm planning to merge if/when the tests pass. |
This is an alternative attempt at fixing the problem identified and addressed in #215 regarding the "pretty printing" of single- and double-quotes. In this attempt, I asked myself why we *ever* needed to do the `gsub` replacement of escaped double-quote characters with single-quote characters. I couldn't come up with a reason other than to make the tests more readable. Thus in this commit I've removed the custom implementation of `String#mocha_inspect` so it falls back to the default `String#inspect` implementation. As far as I can see the error messages are still sensibly formatted and by using the `%{}` string literal construction, I think the tests are still perfectly readable. I hope that this is a simpler and more robust way to solve the problems that @neonichu was seeing.
chrisroos
force-pushed
the
fix-mocha-inspect-on-strings
branch
from
75fcee5
to
f187d30
Compare
|
I've rebased and force-pushed again. I'll merge once the tests pass. |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative attempt at fixing the problem identified
and addressed in #215 regarding the "pretty printing" of single- and
double-quotes.
In this attempt, I asked myself why we ever needed to do the
gsubreplacement of escaped double-quote characters with single-quote characters.
I couldn't come up with a reason other than to make the tests more readable.
Thus in this commit I've removed the custom implementation of
String#mocha_inspectso it falls back to the defaultString#inspectimplementation. As far as I can see the error messages are still sensibly
formatted and by using the
%{}string literal construction, I think thetests are still perfectly readable.
I hope that this is a simpler and more robust way to solve the problems
that @neonichu was seeing.