From d5dd9ab1bde1811a33b288d843d5555498f55952 Mon Sep 17 00:00:00 2001 From: James Mead <3169+floehopper@users.noreply.github.com> Date: Thu, 26 Jul 2018 11:55:35 +0100 Subject: [PATCH] Disable Style/AccessModifierDeclarations for all files This cop was only introduced relatively recently and it seems to have stirred up some controversy [1]. It was being triggered in many of the acceptance tests where anonymous classes are defined within a test and their methods' visibility is specified "inline". [1]: https://github.com/rubocop-hq/rubocop/issues/5953 --- .rubocop.yml | 4 ++++ .rubocop_todo.yml | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 7a36a1e04..425ab24c9 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -54,3 +54,7 @@ Style/WhileUntilModifier: # frozen_string_literal magic comment has only been supported since Ruby v2.3 Style/FrozenStringLiteralComment: Enabled: false + +# This recently introduced cop seems to have stirred up some controversy +Style/AccessModifierDeclarations: + Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e7e29ba1c..9ee4eedd8 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -83,12 +83,6 @@ Metrics/ModuleLength: Metrics/PerceivedComplexity: Max: 11 -# Offense count: 97 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: inline, group -Style/AccessModifierDeclarations: - Enabled: false - # Offense count: 105 Style/Documentation: Enabled: false