Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle track (direct) upload errors more gracefully #120

Open
1 of 3 tasks
chrislo opened this issue Dec 29, 2023 · 2 comments
Open
1 of 3 tasks

Handle track (direct) upload errors more gracefully #120

chrislo opened this issue Dec 29, 2023 · 2 comments

Comments

@chrislo
Copy link
Member

chrislo commented Dec 29, 2023 •
edited

  • enable client side rollbar exception monitoring so we know what's happening when this error occurs
  • recover from error more gracefully
  • maybe we should consider using a 3rd party library to handle these direct uploads (with the assumption that they have better error handling and communication of various states)

Original bug report

An artist got in touch to report some issues uploading an album:

On adding the tunes, I got this error for one of them:

Screenshot 2023-12-29 at 08 40 09

Was able to continue, though…

However, on clicking save and the page refreshing, it came back with this error:

Screenshot 2023-12-29 at 08 49 04

I thought the problem would be Apple Jack, but it wasn’t;t - it was here:

Screenshot 2023-12-29 at 08 49 12

As you can see, all the other tunes were showing no file chosen as well. So, I added them back in. Even though I added here back in, the File Cannot Be Missing message remained for that track.

The save button stopped in its grayed out/deselected state, but clicking on it seemed to work and it all went through as normal.
chrislo added a commit that referenced this issue Dec 29, 2023
@chrislo
Enable client-side exception monitoring with rollbar
1ec986a 
We've had a report (#120) of errors uploading tracks which look like
they're being thrown from the client (likely from the direct upload
javascript). To understand a bit more about what's going on this
commit enables client side exception monitoring.

I added the post_client_item access token from our rollbar
dashboard[1] to the development and production credentials file.

It's quite likely that these exceptions will be a bit noisy, but we
can try to ignore ones we can't do anything about, or revisit having
this enabled once we get to the bottom of what's happening with the
track upload issue.

[1] https://app.rollbar.com/a/gofreerange/p/jam/settings/access_tokens
@chrislo
Copy link
Member Author

chrislo commented Dec 29, 2023

I added client-side exception monitoring in 1ec986a.

@ghost
Copy link

ghost commented Jan 23, 2024

I had the blob error when I tried uploading a compilation. After it happened I clicked the grayed out save button to resume uploads, but they remained stuck, so I had to refresh the page. Result: All my saved data (track uploads, titles, album description, etc) were gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrislo