Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black code formatter to all Python code in this repo #568

Closed
eloquence opened this issue Jun 3, 2020 · 2 comments · Fixed by #569
Closed

Add black code formatter to all Python code in this repo #568

eloquence opened this issue Jun 3, 2020 · 2 comments · Fixed by #569
Assignees

Comments

@eloquence
Copy link
Member

We already enforce black via CI in the launcher directory, but not on the other Python code in this repo. Per our code formatting consensus we want to gradually implement use of black across all SecureDrop repos.

  • with line length set to 100
  • with an ignoreRevsFile to let us skip those revisions for purposes of attribution.
@eloquence
Copy link
Member Author

(Suggesting we exclude isort here for now while we pilot its use in client, and potentially SDK/proxy repos.)

@eloquence eloquence added this to Sprint #52 - 6/3-6/17 in SecureDrop Team Board Jun 3, 2020
@rmol rmol self-assigned this Jun 4, 2020
@eloquence eloquence mentioned this issue Jun 6, 2020
8 tasks
@eloquence eloquence assigned eloquence and unassigned rmol Jun 6, 2020
@eloquence
Copy link
Member Author

eloquence commented Jun 6, 2020

Took a first stab at this in #569; the main immediate issues I see are:

SecureDrop Team Board automation moved this from Sprint #52 - 6/3-6/17 to Done Jun 6, 2020
@eloquence eloquence reopened this Jun 6, 2020
@eloquence eloquence moved this from Done to In Development in SecureDrop Team Board Jun 6, 2020
@eloquence eloquence removed this from In Development in SecureDrop Team Board Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants