Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in nav-collapse margin-inline sizing #1276

Open
janbrasna opened this issue Dec 25, 2023 · 1 comment
Open

Bug in nav-collapse margin-inline sizing #1276

janbrasna opened this issue Dec 25, 2023 · 1 comment
Labels

Comments

@janbrasna
Copy link

Steps to reproduce the issue

  1. Open https://demo.fractal.build demo site on desktop and start making the window smaller
  2. Once it hits breakpoint @include mq($until: nav-collapse) the menu disappears
  3. However the main content is covered or cut off
Screen.Recording.2023-12-26.at.0.03.28.mov

Reproduces how often:

100%

Reduced test case

can be reproduced live, in official demo, and many showcase implementations (ghent, mozilla etc.)

Context

@janbrasna janbrasna added the bug label Dec 25, 2023
@janbrasna
Copy link
Author

I believe there's some flawed logic in

@mixin margin-inline($position, $amount) {

where some of the amounts should be negative, or maybe the whole argument here:

@include margin-inline(end, $width-sidebar);

might be * -1 negative to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant