Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split react adapter helper components into another package #1103

Open
mihkeleidast opened this issue Nov 4, 2021 · 0 comments
Open

Split react adapter helper components into another package #1103

mihkeleidast opened this issue Nov 4, 2021 · 0 comments

Comments

@mihkeleidast
Copy link
Member

What problem would this feature solve?

Currently, when a library uses the PathProvider helper component and depends on it, it also makes it mandatory to install the main @frctl/fractal package in an application that uses the library. This is because @frctl/react requires it as a peerDependency. This is unnecessary, since using only the helper component as a transitive dependency should not mandate using or installing the main Fractal module in an application.

What the feature should look like?

  • Split the components directory in the React adapter into another package, @frctl/react-components.
  • Keep the exports in the React package to provide backwards compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant