Improve handling of verbose testing #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankban
force-pushed
the
improve-verbosity-handling
branch
from
3a81c24
to
d1b245f
Compare
rogpeppe
approved these changes
Sep 26, 2022
report.go
Outdated
Comment on lines
76
to
78
| if !testingVerbose() && strings.Count(v, "\n") >= longValueLines { | ||
| v = "<suppressed because too long, use -v for the full output>" | ||
| } |
There was a problem hiding this comment.
"because too long" reads a bit awkwardly. Also, maybe it might be nice to say just how long it is.
Something like this maybe?
Suggested change
| if !testingVerbose() && strings.Count(v, "\n") >= longValueLines { | |
| v = "<suppressed because too long, use -v for the full output>" | |
| } | |
| if !testingVerbose() { | |
| if n := strings.Count(v, "\n"); n > longValueLines { | |
| v = fmt.Sprintf("<suppressed due to length (%d lines omitted)>", n) | |
| } | |
| } |
report.go
Outdated
| @@ -58,6 +71,11 @@ func writeError(w io.Writer, err error, p reportParams) { | |||
| var v string | |||
| if u, ok := value.(Unquoted); ok { | |||
| v = string(u) | |||
| } else if s, ok := value.(SuppressedIfLong); ok { | |||
| v = p.format(s.Value) | |||
| if !testingVerbose() && strings.Count(v, "\n") >= longValueLines { | |||
There was a problem hiding this comment.
Rather than calling through the global variable (something we've been quite careful to avoid in other tests, cf WithVerbosity), could we not maybe add the verbosity to reportParams somehow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only suppress got/want arguments for CmpEquals (and derived checkers) if the pretty printed representation is small enough and
-vis not provided.