Remove Go < 1.13 support, add Go 1.18 to CI #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This released dropped Go < 1.13 support. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
With actions/setup-go@v3, stable is no longer needed. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
frankban
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly motivated by https://github.com/google/go-cmp/releases/tag/v0.5.8 release which drops support for Go < 1.13.
Go 1.13 was released 2 years and 8 months ago (03 Sep 2019), and is not supported since Go 1.15 is out, i.e. for 1 year and 9 months (since 11 Aug 2020).
Drop Go 1.11 and Go 1.12 from CI, add Go 1.18, plus a nit in gha yaml.
Closes: #139