[BUG] (Cmake) No icons and desktop files installed

[tim77]

Describe the bug
No icons and desktop files installed since v1.6.0 and Cmake port

To Reproduce
Try to compile Fedora build and Cmake macros.

Expected behavior
App compiles fine with icons and desktop files installed as previous v1.5.0 Qmake version.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Fedora 37
• Release version or SHA: ff8c288e00f598a72cccdbf116a28e0441ee3c2011cf99333b835a0a5e9fd5f9
• If manually compiled, compiler version: 12.2.1 20221121 (Red Hat 12.2.1-4) (GCC)

[francescmm]

Hi @tim77, for release purposes I still ship QMake file. I'll modify the Release Notes to indicate that CMake is local build only for now. From the next version on I do plan to fully migrate to CMake.

Nonetheless, I'll take a look and fix this!

[francescmm]

Btw @tim77, I have a couple of questions:

• I cannot find the SHA you provide.
• The Fedora build file you point has some dependencies that are no longer needed: Qt5WebChannel and Qt5WebEngineWidgets.

When I build locally via CMake I don't have any issues with the images, could you attach an image of the result executable?

[tim77]

could you attach an image of the result executable?

Here is full build log and Koji scratch build with new 1.6.0.

I cannot find the SHA you provide.

This one used as sources in build https://github.com/francescmm/GitQlient/releases/download/v1.6.0/gitqlient_1.6.0.tar.gz

The Fedora build file you point has some dependencies that are no longer needed: Qt5WebChannel and Qt5WebEngineWidgets.

Thanks! I'll fix this in next build.

[francescmm]

I think I know what's going on. In the qmake file I have this step for the make install that might be missing in the CMakeLists.

I'll try to fix it as soon as possible, but if you don't mind, could you use QMake for this release?

[tim77]

could you use QMake for this release?

Sure. Thaw was the plan until future releases with Cmake build polishing.

[francescmm]

@tim77 Just FYI, I read the other day that the configuration I use in QMake for the make insstall, will be available in CMake with the release of Qt 6.5, I need to investigate that further.