Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): Improve type definitions for framework7-vue/bundle #4075

Merged
merged 1 commit into from Oct 31, 2022
Merged

fix(vue): Improve type definitions for framework7-vue/bundle #4075

merged 1 commit into from Oct 31, 2022

Conversation

peitschie
Copy link
Contributor

The framework7-vue type definitions inaccurately suggest registerComponents is exported by the framework7-vue module. The package.json also lacks any way for TypeScript to tell what the type definitions are for the bundle module.

This slight adjust fixes both of these requirements. The hint on using typeVersions comes from https://stackoverflow.com/a/70020984/156169

Before these fixes:
image

After these fixes, this is what TypeScript reports:
image

@nolimits4web nolimits4web merged commit 7d68a65 into framework7io:master Oct 31, 2022
@peitschie peitschie deleted the vue-improvements branch October 31, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peitschie @nolimits4web