Adding animation events to motion value #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvh
reviewed
Dec 13, 2022
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - `.on()` event method to `MotionValue`. | ||
| - `"animationStart"`, `"animationComplete"`, and `"animationCancel"` events for `MotionValue`. |
nvh
reviewed
Dec 13, 2022
| const value = motionValue(0) | ||
| const callback = jest.fn() | ||
|
|
||
| value.on("change", callback) |
There was a problem hiding this comment.
Are we keeping the old API around?
nvh
reviewed
Dec 13, 2022
Comment on lines
+160
to
174
| * @deprecated | ||
| */ | ||
| onChange(subscription: Subscriber<V>): () => void { |
There was a problem hiding this comment.
Ha. I think it's so widely used by us I won't even throw in a warning yet. I'm gonna drop it in the docs and then revisit in 6 months or so, maybe add a warning then.
nvh
approved these changes
Dec 13, 2022
mattgperry
force-pushed
the
fix/motion-value-events
branch
from
4f9e17d
to
44debdd
Compare
mattgperry
force-pushed
the
fix/motion-value-events
branch
from
b22d637
to
bc5c76a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1824
This PR adds a new event subscription method to motion values,
.on(), along with three new motion value events,"animationStart","animationComplete"and"animationCancel".This allows multiple event handlers to be attached to the same motion value.