Removing support for mouse and touch events #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgperry
commented
Nov 2, 2022
packages/framer-motion/package.json
Outdated
| @@ -73,31 +73,31 @@ | |||
| "bundlesize": [ | |||
| { | |||
| "path": "./dist/size-rollup-motion.js", | |||
| "maxSize": "29.40 kB" | |||
| "maxSize": "29.12 kB" | |||
There was a problem hiding this comment.
This one is the "real" saving - the others saw a similar decrease with the class PR and are likely from a previous PR.
nvh
reviewed
Nov 3, 2022
| @@ -1,6 +1,6 @@ | |||
| import "@testing-library/jest-dom" | |||
| // Get fireEvent from the native testing library | |||
| // because @testing-library/react one switches out mouseEnter and mouseLeave | |||
| // because @testing-library/react one switches out pointerEnter and pointerLeave | |||
There was a problem hiding this comment.
Is this true for pointerEnter and pointerLeave too?
nvh
approved these changes
Nov 3, 2022
| @@ -1,6 +1,6 @@ | |||
| import "@testing-library/jest-dom" | |||
| // Get fireEvent from the native testing library | |||
| // because @testing-library/react one switches out mouseEnter and mouseLeave | |||
| // because @testing-library/react one switches out pointerEnter and pointerLeave | |||
Comment on lines
21
to
35
| export const pointerEnter = (element: Element) => | ||
| act(() => { | ||
| fireEvent.mouseEnter(element) | ||
| fireEvent.pointerEnter(element) | ||
| }) | ||
| export const mouseLeave = (element: Element) => | ||
| export const pointerLeave = (element: Element) => | ||
| act(() => { | ||
| fireEvent.mouseLeave(element) | ||
| fireEvent.pointerLeave(element) | ||
| }) | ||
| export const mouseDown = (element: Element) => | ||
| export const pointerDown = (element: Element) => | ||
| act(() => { | ||
| fireEvent.mouseDown(element) | ||
| fireEvent.pointerDown(element) | ||
| }) | ||
| export const mouseUp = (element: Element) => | ||
| export const pointerUp = (element: Element) => | ||
| act(() => { | ||
| fireEvent.mouseUp(element) | ||
| fireEvent.pointerUp(element) |
There was a problem hiding this comment.
I assume these are now unused and we can just remove this whole file.
Comment on lines
145
to
+148
| // If we have more than one touch, don't start detecting this gesture | ||
| if (isTouchEvent(event) && event.touches.length > 1) return | ||
| if (!event.isPrimary) return |
There was a problem hiding this comment.
Can't we just remove this completely
Comment on lines
202
to
205
| // Because Safari doesn't trigger mouseup events when it's above a `<select>` | ||
| if (isMouseEvent(event) && event.buttons === 0) { | ||
| if (event.isPrimary) { |
There was a problem hiding this comment.
This comment is probably no longer true, and I wonder if we should keep the logic
mattgperry
force-pushed
the
fix/pointer-events
branch
from
5c4a633
to
22a2d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointer events are extremely well supported, this PR removes support for mouse and touch event fallbacks. Saves almost 0.3kb from the
motioncomponent.