Adding isValidProp to MotionConfig #1410
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e7667a:
|
mattgperry
force-pushed
the
feature/inject-is-valid-prop
branch
from
1ea3c2b
to
bc17fa7
Compare
|
|
||
| const { container } = render(<Component />) | ||
|
|
||
| expect(container.firstChild).not.toHaveAttribute("data-foo") |
There was a problem hiding this comment.
Should we also test that a valid attribute is forwarded to the DOM?
src/render/dom/utils/filter-props.ts
Outdated
| @@ -3,6 +3,16 @@ import { isValidMotionProp } from "../../../motion/utils/valid-prop" | |||
|
|
|||
| let shouldForward = (key: string) => !isValidMotionProp(key) | |||
|
|
|||
| export type IsValidProp = (key: string) => boolean | |||
|
|
|||
| export function loadExternalIsValidProp(emotionIsPropValid?: IsValidProp) { | |||
There was a problem hiding this comment.
Why do we still call it emotionIsPropValid if it could be a user-provided function?
src/render/dom/utils/filter-props.ts
Outdated
|
|
||
| // Handle events explicitly as Emotion validates them all as true | ||
| shouldForward = (key: string) => | ||
| key.startsWith("on") ? !isValidMotionProp(key) : emotionIsPropValid(key) |
There was a problem hiding this comment.
If there's an injected isValidProp provided by MotionConfig, wouldn't it be hijacked by isValidMotionProp? For example, isValidProp={key => key !== "onStart"}
There was a problem hiding this comment.
I think that might have to be a limitation of the API that our events are always consumed
mattgperry
force-pushed
the
feature/inject-is-valid-prop
branch
from
bc17fa7
to
2f7ba17
Compare
|
@shuangq Great comments, I've just pushed some changes |
This PR adds an
isValidPropprop toMotionConfigthat allows the external injection of anisValidPropfunction.Fixes #1406