Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing unit conversion for translation #1337

Merged
merged 3 commits into from Nov 5, 2021
Merged

Fixing unit conversion for translation #1337

merged 3 commits into from Nov 5, 2021

Conversation

mattgperry
Copy link
Collaborator

Fixes #1336

@mattgperry mattgperry requested a review from nvh November 5, 2021 10:50
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d55565:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration
dazzling-darwin-j050s Issue #1336

nvh
nvh reviewed Nov 5, 2021
View reviewed changes
src/render/dom/utils/unit-conversion.ts
positionalValues[key](originBbox, elementComputedStyle)
)

setAndResetVelocity(value, origin[key])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this would fix it?

Copy link
Collaborator Author

@mattgperry mattgperry Nov 5, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah its in the comment in the previous line - computed style is live so we need to grab these before we trigger a render

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how did this regress then?

@mattgperry mattgperry added the automerge Land this PR label Nov 5, 2021
@mergetron mergetron bot merged commit 42d8da7 into main Nov 5, 2021
@mergetron mergetron bot deleted the fix/x-conversion branch November 5, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvh nvh nvh approved these changes

Assignees
No one assigned
Labels
automerge Land this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Using CSS variables doesn't trigger animation (version 5.0.2 and above)
2 participants
@mattgperry @nvh