cast run crashes when execution transactions from a hardhat node

[pedroyan]

Component

Cast

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (63ed109 2022-08-09T00:03:50.892098571Z)

What command(s) is the bug in?

cast run

Operating System

Linux

Describe the bug

When running cast run with a transaction from a hardhat node, cast crashes

Running command with RUST_LOG=backend,node,miner outputs:

[onbjerg]

Probably related to us not padding some parameters correctly for Hardhat

[pedroyan]

@onbjerg I think your hypothesis is correct, given how the ethers maintainers fixed their issue when interfacing with hardhat

ethers-io/ethers.js#2982

[pedroyan]

I'm also getting this problem when deploying some contracts using forge. If I were to guess what's happening, I think the foundry cli tools are not adhering to the RPC spec that says the storage slot in eth_getStorageAt should have a length of 66 (0x + 32 bytes).

The current workaround is to revert the hardhat node to a version that came before this pr (NomicFoundation/hardhat#2581), which accepts arguments that do not strictly follow the spec

[aathan]

I came to report this same thing (errors using the script functionality to deploy to hardhat) and realized this is related to the report I made in hardhat#2581. Not sure if this callsite is the same one that was involved in that older issue (#1297). Would be lovely to not have to hold back hardhat version.

ERROR sharedbackend: Failed to send/recv `storage` err=GetStorage(0x5b73c5498c1e3b4dba84de0f1833c4a029d90519, 2, 
(code: -32602, message: Errors encountered in param 1: Storage slot argument must have a length of 66 ("0x" + 32 bytes), but '0x2' has a length of 3, data: Some(Object({"message": String("Errors encountered in param 1: Storage slot argument must have a length of 66 (\"0x\" + 32 bytes), but '0x2' has a length of 3")})))) address=0x5b73c5498c1e3b4dba84de0f1833c4a029d90519 index=2

[mattsse]

this is a bit confusing because this spec does say it's a QUANTITY

https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getstorageat

https://www.quicknode.com/docs/ethereum/eth_getStorageAt

[aathan]

I see you've been talking to the HH guys but I honestly believe they made a mistake with the spec. I'm going to post over there...

[pedroyan]

@aathan you really did the lord's work here by chasing this down on multiple repos in the Ethereum space (including raising this to the ethereum team on their spec), and thanks to that, made the ecosystem a little better for everyone :)

@mattssee - feel free to close this now if you want! Just tested the script that was throwing this error against Hardhat v2.11.2 (which includes NomicFoundation/hardhat#3177) and confirmed that's no longer the case

[aathan]

Thanks for the shoutout @pedroyan . I think there may remain a concern about "QUANTITY" handling across the same constellation of projects (NomicFoundation/hardhat#3164 (comment)). Just something to keep your eyes on. I'll be back if I run into anything that seems related.

[mattsse]

awesome, thank you so much @aathan

[gakonst]

indeed - great work tracking this down @aathan, thank you!