Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only do compression if requested explictly when forwarding/fetching #625

Merged
merged 7 commits into from Sep 19, 2022

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Sep 18, 2022

fixes #624

also

  • fix a data race
  • enable delay,close and header query args for debug endpoint
  • improved tests

…ixes #624) also fix a data race and also enable delay,close and header query args for debug endpoint
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Base: 88.5% // Head: 88.5% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (4c0031e) compared to base (c72b231).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #625   +/-   ##
======================================
  Coverage    88.5%   88.5%           
======================================
  Files          30      30           
  Lines        4340    4345    +5     
======================================
+ Hits         3839    3844    +5     
  Misses        336     336           
  Partials      165     165           
Impacted Files Coverage Δ
fhttp/http_forwarder.go 90.3% <100.0%> (+0.1%) ⬆️
fhttp/http_server.go 81.0% <100.0%> (+0.2%) ⬆️
periodic/periodic.go 93.6% <100.0%> (+<0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly merged commit c9eaf5e into master Sep 19, 2022
@ldemailly ldemailly deleted the fix_gzip branch September 19, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept-Encoding: gzip header added by fetch2 handler
3 participants