You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"It took me (too) long to realise that you are setting err here for line 383 if I'm honest. Same goes for the logic at line 394.
I do understand you want to reuse the contex of the logger... but then maybe make a small func as in "return err with context" and then do something like"
returnnil, returnErrorWithContext("invalid url")
where returnErrorWithContext func is the contents of:
log.S(log.Error, "Unable to make request",
log.Attr("method", method), log.Attr("url", o.URL), log.Attr("err", err),
log.Attr("thread", o.ID), log.Attr("run", o.UniqueID))
From Wiard
"It took me (too) long to realise that you are setting
err
here for line 383 if I'm honest. Same goes for the logic at line 394.I do understand you want to reuse the contex of the logger... but then maybe make a small func as in "return err with context" and then do something like"
where
returnErrorWithContext
func is the contents of:Originally posted by @wiardvanrij in #785 (comment)
see thread
The text was updated successfully, but these errors were encountered: