Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better names for CallNoPayload -> Get and CallWithPayload -> Fetch #622

Merged
merged 3 commits into from Sep 12, 2022

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Sep 10, 2022

Better names for CallNoPayload -> Get and CallWithPayload -> Fetch (and thus Fetch -> FetchBytes to free up that short name)

This came up while using the API internally

…nd thus Fetch -> FetchBytes to free up that short name)
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Base: 88.4% // Head: 88.4% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (f576daa) compared to base (83ce661).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #622   +/-   ##
======================================
  Coverage    88.4%   88.4%           
======================================
  Files          30      30           
  Lines        4309    4313    +4     
======================================
+ Hits         3810    3814    +4     
  Misses        335     335           
  Partials      164     164           
Impacted Files Coverage Δ
jrpc/jrpcClient.go 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly merged commit 0d61b4f into master Sep 12, 2022
@ldemailly ldemailly deleted the jrpc_refine branch September 12, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants