Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-gomaxprocs and other CLI args do not work with fortio server #482

Open
amarjayr opened this issue Jul 11, 2021 · 1 comment
Open

-gomaxprocs and other CLI args do not work with fortio server #482

amarjayr opened this issue Jul 11, 2021 · 1 comment

Comments

@amarjayr
Copy link

Running fortio server -gomaxprocs=16 does not have any affect on runtime.GOMAXPROCS.

The only place where runtime.GOMAXPROCS is set is fortio_main.go:357 which processes the fortio load command.

I'm happy to add a PR to either add a gomaxprocs field to the fortio server UI or have fortio server -gomaxprocs=16 parsed correctly on the CLI. Please advise which is preferable.

@ldemailly
Copy link
Member

ldemailly commented Oct 22, 2021

While in the golang that fortio builds are using it probably doesn't need to be changed from the default value (num cores), you are right @amarjayr. I think it can be moved to common part so it would apply to fortio server
I wonder if it would really need to be changeable per request

Side question: did you check what happens in k8s env, is the value related to request/limit or using the node's value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants