From 1a5a8baffdbd52c238068cf82937d1411fdb1973 Mon Sep 17 00:00:00 2001
From: Laurent Demailly <ldemailly@gmail.com>
Date: Sun, 24 Mar 2024 12:02:13 -0700
Subject: [PATCH] Update release readme for new shared workflows (#910)

* Update release readme for new shared workflows

* build-push-action is v5 (update outdated pin comment)
---
 .github/workflows/main.yml | 2 +-
 .gitignore                 | 1 +
 codecov.yml                | 1 -
 release/README.md          | 8 ++++----
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 785f4f91c..5c6bc355b 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -40,7 +40,7 @@ jobs:
           echo "Version $VERSION, Package version $PACKAGE_VERSION"
 
       - name: Build and push Docker image
-        uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0 # pin@v3
+        uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0 # pin@v5
         with:
           context: .
           platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
diff --git a/.gitignore b/.gitignore
index 82b662a39..19e991998 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
 # linter config now comes from shared workflows
 .golangci.yml
+coverage.out*
 tmp/
 coverage.txt
 *.bak
diff --git a/codecov.yml b/codecov.yml
index c0a5de73c..41e6de043 100644
--- a/codecov.yml
+++ b/codecov.yml
@@ -4,4 +4,3 @@ coverage:
   round: nearest       # how coverage is rounded: down/up/nearest
   ignore:              # files and folders that will be removed during processing
     - "**.pb.go"
-    - "dflag/test_utils.go"
diff --git a/release/README.md b/release/README.md
index 471a55a17..a8a1b9910 100644
--- a/release/README.md
+++ b/release/README.md
@@ -1,6 +1,6 @@
 # How to make a fortio release
 
-- All the builds and docker, except the build image updates, are now fully automated through github actions based on tags
+- All the builds and docker, except the build image updates, are now fully automated through github actions based on tags and most if shared from org wide https://github.com/fortio/workflows#workflows except for goreleaser which isn't used here and we maintain our own build image (see for instance fortiotel for newer build fully using the shared workflows)
 
 - Make sure to use the same git tag format (e.g "v0.7.1" - note that there is `v` prefix in the tag, like many projects). Docker and internal version/tag is "0.7.1", the `v` is only for git tags.
 
@@ -22,7 +22,7 @@
 
 - To update the command line flags in the ../README.md; run the new `release/bumpRelease.sh 1.53.0` for instance
 
-- Update the homebrew tap `brew bump-formula-pr --tag v1.2.3 fortio`
+- Update the homebrew tap `brew bump-formula-pr --tag v1.2.3 fortio` (brew team usually does this fairly often on their own)
 
 
 ## How to change the build image
@@ -50,8 +50,8 @@ make update-build-image-tag SED=gsed
 
 Check the diff and make lint, webtest, etc and PR
 
-Regularly update pinned github actions
-using https://github.com/mheap/pin-github-action
+Dependabot will regularly update pinned github actions - to pin a new dependency:
+Use https://github.com/mheap/pin-github-action
 ```
 npm install -g pin-github-action
 ```