Warning for deprecated method Object#=~ #1314
Comments
|
A simpler pull request. #1317 |
Closed
benbaumann95
added a commit
to alphagov/support
that referenced
this issue
Sep 10, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained depencies... - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/support
that referenced
this issue
Sep 10, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained depencies... - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/support
that referenced
this issue
Sep 10, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained depencies... - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/support
that referenced
this issue
Sep 10, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/support
that referenced
this issue
Sep 15, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
cdccollins
added a commit
to alphagov/maslow
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. - The decision was made to remove formtastic and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/maslow
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/maslow
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 16, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 16, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 17, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
|
Will this be merged soon? |
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 18, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
|
@raresroca05 you can see my review on both PRs. They are missing a test case and possibly can trigger an exception. |
cdccollins
added a commit
to alphagov/publisher
that referenced
this issue
Sep 24, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/publisher
that referenced
this issue
Sep 24, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/publisher
that referenced
this issue
Sep 24, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/publisher
that referenced
this issue
Sep 24, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/publisher
that referenced
this issue
Sep 25, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 25, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 25, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
cdccollins
added a commit
to alphagov/places-manager
that referenced
this issue
Sep 25, 2020
- Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap has not had a release since 23/02/14 and has been archived) requiring some monkey patching to make it work. - The decision was made to remove both gems and re-write the forms natively. This should be far more future-proof and removes unmaintained dependancies - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 28, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 28, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 28, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 28, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 28, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
benbaumann95
added a commit
to alphagov/travel-advice-publisher
that referenced
this issue
Sep 29, 2020
… gems - Updating to ruby 2.7.1 leads to loads of deprecation warnings as per formtastic/formtastic#1314. Using the fixed patch 4.0.0.rc1 makes the unmaintained formtastic-bootstrap gem incompatible (https://github.com/mjbellantoni/formtastic-bootstrap). It has not had a release since 23/02/14 and has been archived since, requiring some monkey patching to make it now work. - The decision was made to remove both of these gems and re-write the forms natively. This should be far more future-proof and it's always good to get rid of some unmaintained dependencies... - Removed lib/formtastic_extension.rb and added back the static jquery template with up to date changes (i.e. reverting this 4fde824). The code here isn't very manageable and with the removal of formtastic it didn't make sense to try monkey patch to make it work. - There should be no cosmetic change to the forms, as the relevant bootstrap classnames has been added to the HTML, including any accessibility tags.
|
Is everyone seeing this warning for ActiveAdmin? Or are there some other cases where |
|
None of our current tests in activeadmin currently show this warning. Otherwise, having a way to reproduce it, I'd come here and try to add a proper test. That doesn't mean this is not a bug in activeadmin, but I thought it could be useful information. |
|
Looks like you're looking for people with this problem? We have it so we are monitoring this issue. If you're having trouble replicating, I'll see if I can make an example over the next few days. |
|
Yeah, I mean, as per @mikz's comments, we're also looking for a regression spec and making sure the proposed fixes won't make any cases crash. But having a way to reproduce it also unblocks us to have a look at it ourselves. |
|
Hope this is of some help https://github.com/pctj101/formtastic_deprecation_demo chruby 2.7.1 mysqldump in ft.sql uname -a -> Darwin dev.local 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64 |
|
We're also waiting for the fix. Thanks in advance. |
|
I managed to repro with @pctj101's app on my system. I'll try to take a look soon. |
|
Actually, I can't repro this with formtastic 4.0.0.rc1. Could you double check? You can opt-in to the prerelease by adding |
|
@deivid-rodriguez I confirm, it is fixed in 4.0.0.rc1. One doubt here is - when can we expect 4.0.0? Is 4.0.0.rc1 a stable version that we can use in production? |
|
I think given that it's been more than 3 years since the previous stable release, many people has been pointing to the default branch in github since. So, yeah, I'd say it's fairly stable. That said, the more people try it out, the more issues/regressions will get reported and the more likely it will be that the final version is released. It's the classic chicken and egg issue with prereleases: people won't test them out because of not being stable, and they are not stable because people won't test them out and report issues 🤷♂️. |
|
We'll do the leap of faith then and report if we see any issue :). Thanks for the explanation. |
|
Version 4 can have major changes and be incompatible with version 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Got some warning in ruby 2.7.1, because we used
=~for matching. This method is deprecated. https://ruby-doc.org/core-2.7.1/Object.html#method-i-3D-7EThe text was updated successfully, but these errors were encountered: