Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Migrate: victory-errorbar #2395

Merged
merged 3 commits into from
Aug 3, 2022
Merged

TS Migrate: victory-errorbar #2395

merged 3 commits into from
Aug 3, 2022
+87 −64

Conversation

sblinde
Copy link
Contributor

@sblinde sblinde commented Jul 29, 2022

Description

This PR should migrate victory-errorbar to TypeScript

@sblinde sblinde added the Type: TypeScript Issues related to typescript or type definitions label Jul 29, 2022
@sblinde sblinde self-assigned this Jul 29, 2022
gksander
gksander reviewed Aug 2, 2022
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one little suggestion to avoid using non-null assertion (! operator). We just need to let TS know that we have some default props available so that groupComponent won't be undefined at runtime.

@sblinde
Updating the error bar props

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6c7a4f4
gksander
gksander approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gksander
Copy link
Contributor

gksander commented Aug 3, 2022

Oh shoot, I keep forgetting this – but can you run pnpm changeset and add a patch changeset for this work? See here for more deets.

@sblinde
Copy link
Contributor Author

sblinde commented Aug 3, 2022

Oh shoot, I keep forgetting this – but can you run pnpm changeset and add a patch changeset for this work? See here for more deets.

Absolutely! Sorry I missed doing so in the last PR but I will for this one!

@sblinde
Adding changeset

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fed5a50
@sblinde sblinde merged commit 6aa7656 into main Aug 3, 2022
@sblinde sblinde deleted the feature/migrate-errorbar-to-ts branch August 3, 2022 15:14
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gksander gksander

Assignees

@sblinde sblinde

Labels
Type: TypeScript Issues related to typescript or type definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sblinde @gksander