Skip to content

Type export should not be with other exports #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

khevamann
Copy link
Contributor

This fixes an issue with types throwing an error #2355

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This fixes an issue with types throwing an error FormidableLabs#2355

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@scottrippey
Copy link
Member

Sorry for the delay on this, but thank you for making the change!
The new export { type ... } syntax is not as well-supported as export type { ... } so this is a good improvement. Thanks!

@scottrippey scottrippey merged commit 14d7bb1 into FormidableLabs:main Aug 1, 2022
@j-mcgregor
Copy link

j-mcgregor commented Aug 2, 2022

Thanks for fixing this @khevamann , do you know when it will be included in a release? It's blocking my project building. Thanks!

@scottrippey
Copy link
Member

We will publish this week for sure, just have to fix a publishing issue.

@j-mcgregor
Copy link

We will publish this week for sure, just have to fix a publishing issue.

Thanks!

@scottrippey
Copy link
Member

Published as 36.6.0! Thanks for the contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants