feat(@formatjs/intl,react-intl): move IntlFormatter type parameters to methods #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlho
requested changes
Oct 1, 2022
|
I probably butchered the typing of |
longlho
reviewed
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3856
Fixes #3707
IntlFormattersonly take one type parameterTBase, which is the type constraint of the rich text element. For React, this will beReact.ReactNode, requiring the rich text element to extend fromReact.ReactNode.formatMessage,$t, andformatListnow types the type parameterT, which must satisfyT extends TBase. Doing so makes the formatter typing parametric to the callsite, which is more accurate than instantiating the type parameter on theIntlFormattersor its subtypes.