Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower or remove Node version requirement for @formatjs/cli-lib #3715

Closed
lassegit opened this issue Jul 18, 2022 · 4 comments
Closed

Lower or remove Node version requirement for @formatjs/cli-lib #3715

lassegit opened this issue Jul 18, 2022 · 4 comments
Labels

Comments

@lassegit
Copy link

lassegit commented Jul 18, 2022

Which package?

@formatjs/cli-lib

Describe the bug

Since version 5 @formatjs/cli isn't dependent on Vue packages requiring a minimum Node version to work, thus rendering formatjs/cli does not respect @vuejs/core's engines.node >= 16.5.0 requirement #3602 obsolete. Can we lower the Node engine required to say 14.x or completely remove it? I reckon lot of projects are using lower version than 16.5 and then they can't benefit from the upgrade (which removed a lot of unneeded Vue dependencies).

compiler-sfc doesn't specify any particular Node version.

Edit: Just updated this issue to be about @formatjs/cli-lib and not @formatjs/cli.

@lassegit lassegit added the bug label Jul 18, 2022
@lassegit
Copy link
Author

@longlho What do you say? :)

@lassegit lassegit changed the title Lower or remove Node version requirement for @formatjs/CLI Lower or remove Node version requirement for @formatjs/cli-lib Jul 18, 2022
@longlho
Copy link
Member

longlho commented Jul 19, 2022

technically we can lower it but we don't test against 14.x so there's no guarantee it actually works.

@lassegit
Copy link
Author

In that case it makes sense, just unsure the percentage still using lower than version 16. But maybe not so many.

@abdel-ships-it
Copy link

@lassegit I think if this change is harmless, we should get rid of the engine requirement. I'm personally still on v14 due to certain constraints and cannot use this package because of that.

Hearing engine requirement is there because of vue packages in the past, while being on react is somewhat frustrating. Having said that I would greatly appreciate it if you consider removing the engine requirement from the cli package. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants