Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intl-listformat] Incorrect comments #2716

Labels

Comments

@nstepien
Copy link
Contributor

Which package?

intl-listformat

Describe the bug

The comments describing the possible values in IntlListFormatOptions/ResolvedIntlListFormatOptions don't match with reality.
type is plain wrong
style probably comes from intl-relativetimeformat

To Reproduce

Read the comments: https://github.com/formatjs/formatjs/blob/main/packages/intl-listformat/index.ts#L27

Codesandbox URL

N/A

Reproducible Steps/Repo

Steps to reproduce the behavior:

  1. Open https://github.com/formatjs/formatjs/blob/main/packages/intl-listformat/index.ts#L27
  2. Read

Expected behavior

Valid documentation

Screenshots

N/A

Desktop (please complete the following information):

  • OS: N/A
  • Browser: N/A
  • Version: N/A

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser N/A
  • Version N/A

Additional context

None

@nstepien nstepien added the bug label Mar 16, 2021
@nstepien
Copy link
Contributor Author

@longlho longlho reopened this Mar 17, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment