Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@formatjs/cli): add string_format:icu config to smartling formatter #2528

Merged
merged 1 commit into from Jan 22, 2021
Merged

fix(@formatjs/cli): add string_format:icu config to smartling formatter #2528

merged 1 commit into from Jan 22, 2021

Conversation

hjylewis
Copy link
Contributor

fixes #2526

@longlho longlho merged commit eec1c6f into formatjs:main Jan 22, 2021
@longlho
Copy link
Member

longlho commented Jan 22, 2021

Thanks a lot for your contributions!

@hjylewis
Copy link
Contributor Author

My pleasure! Do you mind publishing this change? It will be helpful in a PR I'm working on for work. Thanks!

@longlho
Copy link
Member

longlho commented Jan 22, 2021

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smartling formatter missing string_format:icu
2 participants
@hjylewis @longlho