Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartling formatter missing string_format:icu #2526

Closed
hjylewis opened this issue Jan 21, 2021 · 0 comments · Fixed by #2528
Closed

Smartling formatter missing string_format:icu #2526

hjylewis opened this issue Jan 21, 2021 · 0 comments · Fixed by #2528
Labels

Comments

@hjylewis
Copy link
Contributor

hjylewis commented Jan 21, 2021

Which package?

cli

Describe the bug

According to the smartling docs, the smartling configuration should also include the property string_format: "icu" to indicate that the messages are ICU MessageFormat.

So the SmartlingDirectives should be

{
  smartling: {
    translate_paths: [
      {
        path: '*/message',
        key: '{*}/message',
        instruction: '*/description',
      },
    ],
    variants_enabled: true,
    string_format: 'icu'
  },
}

I'll try to open a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant