Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(babel-plugin-react-intl): idInterpolationPattern #2311

Merged
merged 2 commits into from Nov 15, 2020
Merged

fix(babel-plugin-react-intl): idInterpolationPattern #2311

merged 2 commits into from Nov 15, 2020

Conversation

johakr
Copy link
Contributor

@johakr johakr commented Nov 14, 2020

fixes interpolation of [name], [folder] etc. in idInterpolationPattern

@johakr
fix(babel-plugin-react-intl): idInterpolationPattern
8d6991e 
fixes interpolation of `[name]`, `[folder]` etc. in idInterpolationPattern
@longlho
Copy link
Member

longlho commented Nov 15, 2020

Thanks for the PR. Can you add tests as well?

@johakr
Copy link
Contributor Author

johakr commented Nov 15, 2020

@longlho sure, adjusted existing tests to cover that.

@longlho
Copy link
Member

longlho commented Nov 15, 2020

Thanks a lot for your contributions!

@longlho longlho merged commit 2cb1249 into formatjs:main Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johakr @longlho