Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added className and style props to all components #134

Closed
wants to merge 1 commit into from

Conversation

endragor
Copy link

Closes #72.

@yahoocla
Copy link

CLA is valid!

@caridy
Copy link
Collaborator

caridy commented Jun 30, 2015

dupe of #131, tagName is being discussed there. classname and style are out of the question for me because you can achieve the same by wrapping the component, without blacklisting potential tokens to be used in ICU messages.

@caridy caridy closed this Jun 30, 2015
@endragor
Copy link
Author

Then could you please leave this comment in #72 and close it, too? This is not really a dupe of #131.
Yes, I may achieve the same by wrapping, but the layout (DOM) becomes way more verbose and ugly, if I wrap the FormattedMessage into spans everywhere.

@endragor
Copy link
Author

I'll then just add wrapper component in my own project, but it's still worth commenting and closing #72, so that your opinion is clear and noone else tries to do this work in vain.

@caridy
Copy link
Collaborator

caridy commented Jun 30, 2015

yeah, apologies for not being clear on that issue, I will sync up with @ericf about this.

@ericf
Copy link
Collaborator

ericf commented Jun 30, 2015

If there was a way to output a pure DOM text node, that's what we'd do from these components; but since there isn't, we have to use a <span> which is the more inert element.

We should add docs to the website which explain how to style these components via wrapping them.

longlho pushed a commit that referenced this pull request Apr 27, 2020
longlho pushed a commit that referenced this pull request Apr 27, 2020
BREAKING CHANGE: This changes how we escape chars in messages, instead of `\` we now use apostrophe which is more aligned with ICU4J & ICU4C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants