getDefaultProps overrides properties passed from parent component

[borodyadka]

Hi. There is a problem with passing of messages to children of my top component. Using of getDefaultProps overrides any messages passed from parent. I've using it for default translations, maybe there is another way to do it.

Here I've prepare an example of bug.

If I comment getDefaultProps in my ChildComponent then test passes.

[ericf]

What behavior were you expecting? A merge of messages?

You could do this:

const ChildComponent = React.createClass({
    mixins: [ReactIntl.IntlMixin],

    getDefaultProps() {
        return {
            messages: Object.assign({}, this.context.message, {
                foo: 'Foo'
            })
        }
    },

    render() {
        return (
            <FormattedMessage message={this.getIntlMessage('foo')} />
        );
    }
});

[borodyadka]

Thanks for answer. I've expected override of default messages with new.

Your example doesn't work. I've got an error: TypeError: Cannot read property 'messages' of undefined.

Looks like this.context and this.props is undefined in getDefaultProps.

Before I've used a hack like this:

render() {
    this.props.messages = this.props.messages ? this.props.messages : getDefaultMessages();
    // ...
}

But now I've removed it and pass messages property explicitly.