Extract a method to render an exception output #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we only need this output in certain situations we don't have to render it every time. A common occurrence was an exception containing an object originating from Doctrine that contains large objects or even circular references. Spoon would then attempt to use `var_dump` to display these objects causing memory issues. This commit only attempts to dump variables when necessary, examples being debug mode or callbacks. Most of the time Symfony's debug bundle will take care of error handling in those situations but when that's not available this still outputs all necessary data. Usually you will have a lot more memory available if you are running in debug mode.
carakas
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only need this output in certain situations we don't have to render it every time.
A common occurrence was an exception containing an object originating from Doctrine that contains large objects or even circular references. Spoon would then attempt to use
var_dumpto display these objects causing memory issues.This commit only attempts to dump variables when necessary, examples being debug mode or callbacks.
Most of the time Symfony's debug bundle will take care of error handling in those situations but when that's not available this still outputs all necessary data. Usually you will have a lot more memory available if you are running in debug mode.
Apologies in advance for the rather chaotic commit but the code styles were driving me crazy.