Replaced optimist with yargs #1093
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For testing via github directly.
tweaked
Ratstail91
changed the title
kibertoad
reviewed
Jul 26, 2020
kibertoad
reviewed
Jul 26, 2020
|
Looks good, thanks a lot! Could you address a couple of very minor comments? |
|
Sure! I've addressed the comments. I can remove the redundant testing if needed, otherwise she's good to go! |
|
@Ratstail91 Could you please remove the GA part of the PR? I can remove it myself later, but won't have time for this today. |
|
@kibertoad All done! Sorry for the delay! |
kibertoad
approved these changes
Aug 7, 2020
|
Thanks a lot! |
|
Thanks for the fix guys, can we have this as patch release soon? |
|
@hc-12 Sorry it took a while. Released in 3.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, admittedly just a drop-in replacement, but this issue pops up in literally every project I have, and it's driving me nuts.