Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code with double backslash becomes single if it is part of nested bullet list #2288

Closed
learnbyexample opened this issue Apr 2, 2019 · 4 comments
Assignees
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution external contributors welcome contribution is welcome!

Comments

@learnbyexample
Copy link

Describe the bug

Double backslash inside code blocks in nested listing results in single backslash instead of two.

To Reproduce

From any post/comment, try these non-nested and nested bullet lists:

* foo
* use `\\1`, `\\2`, etc

---

* foo
    * baz
* use `\\1`, `\\2`, etc

Expected behavior

Double backslash shouldn't become single, as shown below for GitHub markdown rendering:

  • foo
    • baz
  • use \\1, \\2, etc

Screenshots

Screenshot for above non-nested (correctly rendering) and nested list (incorrect):

nested_bullet_double_backslash

Not sure if this is related to: #960

@jessleenyc jessleenyc added the area: publishing experience issues related to an authors experience publishing. Tags, series, etc. label Apr 2, 2019
@triage-new-issues triage-new-issues bot removed the triage label Apr 2, 2019
@jessleenyc jessleenyc added the external contributors welcome contribution is welcome! label Apr 2, 2019
@Zhao-Andy Zhao-Andy added the bug always open for contribution label Apr 5, 2019
@danascheider
Copy link
Contributor

danascheider commented May 26, 2020

I'm happy to pick this issue up if it's still one the maintainers want done.

@rhymes
Copy link
Contributor

rhymes commented May 26, 2020

@danascheider please go ahead and thank you! I'm going to assign the issue to you

@danascheider
Copy link
Contributor

danascheider commented May 27, 2020

It appears this bug is in the Redcarpet gem, not in dev.to code. I've submitted an issue report against Redcarpet to ask if they'd accept a PR. Unfortunately, the last commit merged on Redcarpet was almost a year ago, and the last time a maintainer responded to an issue report or merged a PR was in January of 2019. The most recent commit to the repository was when version 3.5.0 was released back in July. So basically, there's nothing more I can do with this issue on this codebase unless either (1) the maintainers of Redcarpet accept a PR and release a new version or (2) we want to switch to a different library. Point (2) would probably not be a bad idea if the library we're using isn't being actively maintained anymore, especially since properly escaping HTML is pretty important for security.

So that's where we're at with this - please just let me know how you'd like me to proceed. I'm happy to make a Redcarpet PR in the unlikely event the maintainers respond to my issue report soon, and I could also take on at least some of the work if you want to instead switch to a different library.

EDIT: Turns out the problem is in the C extensions to Redcarpet so that may not be a PR I can make since I don't know C :(

@cmgorton
Copy link
Contributor

Thanks for taking this up and investigating Dana. As this issue looks like it will be blocked for some time I am going to go a head and close it. If the Redcarpet maintainers address the issue in their gem we can open this back up!

@cmgorton cmgorton moved this from Keep this issue/pr to Done in OSS Rotation: Triage stale issues/pr Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution external contributors welcome contribution is welcome!
Projects
No open projects
Development

No branches or pull requests

7 participants