Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests need to adapt to cattrs >= 22.1 new validation mode #224

Closed
madig opened this issue Jun 22, 2022 · 3 comments
Closed

Tests need to adapt to cattrs >= 22.1 new validation mode #224

madig opened this issue Jun 22, 2022 · 3 comments

Comments

@madig
Copy link
Collaborator

madig commented Jun 22, 2022

See https://github.com/python-attrs/cattrs/blob/main/HISTORY.rst#2210-2022-04-03.

Running the tests with the latest cattrs errors out because some exception regexes now would need to dig into the returned error object or something. Disabling extra validation should make it work but eh?
@anthrotype
Copy link
Member

is it only the tests that fail, or is ufoLib2 lib incompatible with cattrs >= 22.1?

@madig
Copy link
Collaborator Author

madig commented Jun 23, 2022

The tests fail because the new validation returns different exceptions (or wrappers, IIUC), happy path functionality is unchanged.

@anthrotype
Copy link
Member

Fixed with #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madig @anthrotype