Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaulate attrs change to attribute setting #186

Open
madig opened this issue Dec 14, 2021 · 1 comment
Open

Evaulate attrs change to attribute setting #186

madig opened this issue Dec 14, 2021 · 1 comment

Comments

@madig
Copy link
Collaborator

madig commented Dec 14, 2021

See python-attrs/attrs#886.

The docs say that @defined dataclasses will change behavior:

Converters and validators are run when you set an attribute (on_setattr=[attr.setters.convert, attr.setters.validate]).

After a version with this change is released, we should go over the code and see if we need to change anything or can simplify something.
@anthrotype
Copy link
Member

we could but mypy can't #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madig @anthrotype